On Sat, Aug 30, 2014 at 3:02 PM, Eric Covener <[email protected]> wrote: > On Tue, Aug 26, 2014 at 5:22 AM, Yann Ylavic <[email protected]> wrote: >> I don't think mod_reqtimeout should handle/count speculative bytes, >> they ought to be read for real later (and taken into account then). >> Otherwise, the same bytes may be counted multiple times. >> >> How about simply forward the ap_get_brigade() call? > > Makes sense -- I did limit it to nonblock as well. Can you take a > look before I propose? http://svn.apache.org/r1621453
I'm not sure we should limit it to nonblock, speculative mode is mainly to be used in non-blocking, but ap_rgetline_core() for example does not (when folding), so mod_reqtimeout may still count header bytes twice. Otherwise, looks good to me. Regards, Yann.
