On Sun, Oct 5, 2014 at 2:09 PM, Kaspar Brand <[email protected]> wrote: > On 05.10.2014 13:55, Yann Ylavic wrote: >> sk_OPENSSL_STRING_value() is undefined in openssl-0.9.8x, I commited a >> follow up in r1629485. >> Can you please check this is the right thing to do? > > Thanks. It would make more sense to change ssl_private.h, actually - you > can just s/sk_OPENSSL_STRING_pop/sk_OPENSSL_STRING_value/ (as r1629372 > dropped the sk_OPENSSL_STRING_pop call, i.e. it's no longer used in > anywhere in mod_ssl).
OK, thanks, done in r1629519. I choose rather to the keep sk_OPENSSL_STRING_pop defined and add sk_OPENSSL_STRING_value/num in ssl_private.h, to avoid this same issue should any of these be used some day for any reason. Regards, Yann.
