Hi Mike, On Thu, Nov 20, 2014 at 10:49 PM, Mike Rumph <[email protected]> wrote: > I would have thought that a MIN macro would already be defined somewhere.
Yes, me too, it was also a motivation for this change (remove MIN). Unfortunately the code was wrong, and it would be more complicated than the original one once fixed (plus the fact that apr_socket_timeout_set() already checks that new_timeout != old_timeout). > If not, perhaps a more central location (some header file) could be chosen > for it. It belongs to APR (along with min/max_t) IMHO. Maybe this could be proposed there... Regards, Yann.
