On Sun, Nov 23, 2014 at 12:25 AM, Eric Covener <[email protected]> wrote: > On Sun, Nov 16, 2014 at 4:32 PM, <[email protected]> wrote: >> @@ -1010,8 +1003,6 @@ static void process_socket(apr_thread_t >> c = ap_run_create_connection(p, ap_server_conf, sock, >> conn_id, sbh, cs->bucket_alloc); >> if (!c) { >> - apr_bucket_alloc_destroy(cs->bucket_alloc); >> - apr_pool_clear(p); >> ap_push_pool(worker_queue_info, p); >> return; >> } > > first line intentional?
Yes, bucket_alloc is created on p just above, we can let it die when p is cleared/destroyed in ap_push_pool(). This saves apr_bucket_alloc_destroy()'s walk/compare on p->cleanups before apr_pool_clear().
