Hi All,
This get's me remembering why we have the generated files in SVN. Not
all OSs have the ability to generate these files, specifically Windows
at the time the expression parser was moved from mod_ssl into core, the
then available version was not new enough. GNU tools are no friend to
Windows :-)
I notice that util_expr_scan.l has been modified and 2.5.35 version of
flex is noted in the commit log. I would like to regenerate the .c but
the best I can do is 2.5.4a (last available version for Win32) which
works but is obviously no where near the current.
Maybe we should comment in the files, you change it, you regenerate the .c?
Regards,
Gregg
On 12/8/2014 11:56 PM, Jan Kaluža wrote:
On 12/08/2014 10:29 PM, Yann Ylavic wrote:
Finally committed in r1643929, generated by bison-2.7.1.
Thanks Yann!
Regards,
Jan Kaluza
On Mon, Dec 8, 2014 at 9:12 PM, Yann Ylavic <[email protected]>
wrote:
Reverted in r1643901.
Someone with a bison version above 2.7.12-4996 should do this (mine
is 2.5).
On Mon, Dec 8, 2014 at 8:48 PM, Yann Ylavic <[email protected]>
wrote:
OK, thanks.
Done in r1643900.
On Mon, Dec 8, 2014 at 7:33 PM, Gregg Smith <[email protected]> wrote:
Hi Yann,
Commit the newly generated files please.
Regards,
Gregg
On 12/8/2014 9:18 AM, Yann Ylavic wrote:
Hi,
commit r1642154 modified server/util_expr_parse.y, hence
server/util_expr_parse.c and server/util_expr_parse.h are
re-generated
by bison during make.
However these .[ch] are also committed in the svn repository...
There is also the same issue with server/util_expr_scan.l wrt
server/util_expr_scan.c (generated by flex), should the former be
modified.
How are we supposed to handle these files upon change of the
bison/flex sources, commit the newly generated files (using the same
bison and flex tools which are not required by the build system
currently), or should we remove the generated files from the svn and
sowehow require any lex/yacc parser at configure time?
Regards,
Yann.
