On 01 Feb 2012, at 5:53 PM, Brian J. France <[email protected]> wrote:
> I had started breaking up the patches from mod_dav_acl into smaller chunks > and getting them imported into the trunk. > > My goal was to get a mod_dav_acl like module added. I say like because > mod_dav_acl currently requires xfs and stores the auth information in the xfs > attributes and I wanted to create a more authn type module. Something that > could have a flat file, dbm, dbd, etc type plugins. > > After mod_dav_acl was done I wanted to get mod_caldav and mod_cardav imported > as well, but free time dried up and I never finished. Keen to revive this again. I just tried to build mod_dav_acl against trunk, and after patching the function signatures for dav_error_new, I get the errors below. There seem to be two key outstanding issues: - dav_error needs to be extended to support childtags, not sure if a patch was submitted for this. - 'dav_resource' has no member named ‘acl_hooks’ - I am not sure what change needs to be made to the mod_dav_acl code (if any) to support this? [minfrin@Host-001 mod_dav_acl]$ make -k make all-recursive make[1]: Entering directory `/home/minfrin/mod_dav_acl' Making all in lib make[2]: Entering directory `/home/minfrin/mod_dav_acl/lib' /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/httpd -DLINUX -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/libxml2 -I/usr/include/apr-1 -g -O2 -MT libdavacl_la-dav_acl.lo -MD -MP -MF .deps/libdavacl_la-dav_acl.Tpo -c -o libdavacl_la-dav_acl.lo `test -f 'dav_acl.c' || echo './'`dav_acl.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/httpd -DLINUX -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/libxml2 -I/usr/include/apr-1 -g -O2 -MT libdavacl_la-dav_acl.lo -MD -MP -MF .deps/libdavacl_la-dav_acl.Tpo -c dav_acl.c -fPIC -DPIC -o .libs/libdavacl_la-dav_acl.o dav_acl.c: In function 'dav_acl_privilege_error': dav_acl.c:80: error: 'dav_error' has no member named 'childtags' dav_acl.c: In function 'dav_acl_exec_error': dav_acl.c:106: error: 'dav_error' has no member named 'childtags' dav_acl.c:106: error: 'dav_error' has no member named 'childtags' dav_acl.c:106: error: 'dav_error' has no member named 'childtags' dav_acl.c:106: error: 'dav_error' has no member named 'childtags' dav_acl.c: In function 'dav_acl_store_owner': dav_acl.c:1509: error: 'dav_resource' has no member named 'acl_hooks' dav_acl.c:1510: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token dav_acl.c:1510: error: 'acl' undeclared (first use in this function) dav_acl.c:1510: error: (Each undeclared identifier is reported only once dav_acl.c:1510: error: for each function it appears in.) dav_acl.c:1516: error: 'dav_resource' has no member named 'acl_hooks' make[2]: *** [libdavacl_la-dav_acl.lo] Error 1 make[2]: Target `all' not remade because of errors. make[2]: Leaving directory `/home/minfrin/mod_dav_acl/lib' Making all in tools make[2]: Entering directory `/home/minfrin/mod_dav_acl/tools' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/minfrin/mod_dav_acl/tools' Making all in man make[2]: Entering directory `/home/minfrin/mod_dav_acl/man' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/home/minfrin/mod_dav_acl/man' make[2]: Entering directory `/home/minfrin/mod_dav_acl' /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/usr/include/httpd -DLINUX -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/libxml2 -I/usr/include/apr-1 -g -O2 -MT mod_dav_acl_la-mod_dav_acl.lo -MD -MP -MF .deps/mod_dav_acl_la-mod_dav_acl.Tpo -c -o mod_dav_acl_la-mod_dav_acl.lo `test -f 'mod_dav_acl.c' || echo './'`mod_dav_acl.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/usr/include/httpd -DLINUX -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/libxml2 -I/usr/include/apr-1 -g -O2 -MT mod_dav_acl_la-mod_dav_acl.lo -MD -MP -MF .deps/mod_dav_acl_la-mod_dav_acl.Tpo -c mod_dav_acl.c -fPIC -DPIC -o .libs/mod_dav_acl_la-mod_dav_acl.o mod_dav_acl.c:884: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'acl' mod_dav_acl.c:893: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token mod_dav_acl.c: In function 'send_principal_props': mod_dav_acl.c:1000: error: 'dav_resource' has no member named 'acl_hooks' mod_dav_acl.c: In function 'davacl_handler': mod_dav_acl.c:1438: warning: assignment makes pointer from integer without a cast mod_dav_acl.c: In function 'initialize_module': mod_dav_acl.c:1529: error: 'acl' undeclared (first use in this function) mod_dav_acl.c:1529: error: (Each undeclared identifier is reported only once mod_dav_acl.c:1529: error: for each function it appears in.) mod_dav_acl.c: At top level: mod_dav_acl.c:1594: warning: excess elements in struct initializer mod_dav_acl.c:1594: warning: (near initialization for 'res_hooks') make[2]: *** [mod_dav_acl_la-mod_dav_acl.lo] Error 1 /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/usr/include/httpd -DLINUX -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/libxml2 -I/usr/include/apr-1 -g -O2 -MT mod_dav_acl_la-acl_liveprops.lo -MD -MP -MF .deps/mod_dav_acl_la-acl_liveprops.Tpo -c -o mod_dav_acl_la-acl_liveprops.lo `test -f 'acl_liveprops.c' || echo './'`acl_liveprops.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/usr/include/httpd -DLINUX -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/libxml2 -I/usr/include/apr-1 -g -O2 -MT mod_dav_acl_la-acl_liveprops.lo -MD -MP -MF .deps/mod_dav_acl_la-acl_liveprops.Tpo -c acl_liveprops.c -fPIC -DPIC -o .libs/mod_dav_acl_la-acl_liveprops.o libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/usr/include/httpd -DLINUX -D_REENTRANT -D_GNU_SOURCE -pthread -I/usr/include/libxml2 -I/usr/include/apr-1 -g -O2 -MT mod_dav_acl_la-acl_liveprops.lo -MD -MP -MF .deps/mod_dav_acl_la-acl_liveprops.Tpo -c acl_liveprops.c -o mod_dav_acl_la-acl_liveprops.o >/dev/null 2>&1 mv -f .deps/mod_dav_acl_la-acl_liveprops.Tpo .deps/mod_dav_acl_la-acl_liveprops.Plo make[2]: *** No rule to make target `lib/libdavacl.la', needed by `mod_dav_acl.la'. make[2]: Target `all-am' not remade because of errors. make[2]: Leaving directory `/home/minfrin/mod_dav_acl' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/minfrin/mod_dav_acl' make: *** [all] Error 2 Regards, Graham —
