On Thu, Jan 8, 2015 at 1:02 PM, Eric Covener <cove...@gmail.com> wrote:
> I am not following (the existing) AH01579. Why is it related to a
> custom error page at that point?

http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?r1=722213&r2=722212&pathrev=722213

There is a short thread responding to the commit email.

I think it's a good check minus the "custom errordocument" slant, and
I think I agree with Yann's remix of it where we just do this check
any time we ap_die with a non-HTTP status before headers have been
written.

I think currently this branch should be pretty rare, as
ap_invoke_handler is filtering this status code for most places we'd
expect it to show up. A non-handler hook or filter returning it
directly are the other paths. Those seem unlikely to pass it to
ap_die().

-- 
Eric Covener
cove...@gmail.com

Reply via email to