On Thu, Jun 18, 2015 at 11:07 AM, Stefan Eissing
<stefan.eiss...@greenbytes.de> wrote:
>
> It retrieves SNI servername via ssl_var_lookup, creates a fake request_rec
> incokes ap_update_vhost_from_headers().
>
> Not very elegant.
>
> a) is there another way?

Maybe define a new ap_get_vhost_from_name() and use it in both
ap_update_vhost_from_headers() and your code.

> b) if not, should the server_rec be a parameter to the alpn callback functions

If that's enough, it looks like a simpler change, though.

> c) or, alternatively, should the conn_rec carry that information somewhere?

Such a base struct is not very easy to change without breaking
compatibility (ABI), that would make any backport to 2.4.x less
acceptable...

Regards,
Yann.

Reply via email to