On 8/25/2015 5:57 PM, William A Rowe Jr wrote:
On Aug 24, 2015 11:43 PM, "Gregg Smith"<[email protected]> wrote:
On 8/24/2015 9:29 AM, Stefan Eissing wrote:
I hope this works for everyone. The next weeks might be a good time to
think about it and propose any changes and correct my mistakes.
There are two things that go bump on my lowest non-eol version of MSVC.
h2_worker.c
.\h2_worker.c(113) : error C2440: 'function' : cannot convert from 'void
*(__cdecl *)(apr_thread_t *,void *)' to 'apr_thread_start_t'
.\h2_worker.c(113) : warning C4022: 'apr_thread_create' : pointer
mismatch for actual parameter 3
Casting execute to apr_thread_start_t (what apr_thread_create expects)
seems to quiet the compiler and FireFox seems to work with it.
That sounds most unsafe. Is this a mismatch between DECLARE and
DECLARE_NONSTD?
Working right now on Linux but will take a few min to look at both issues
you flagged.
I'm sure it was, but I wanted it to build. I did not commit that.
Stefen has dealt with these issues properly I'd imagine in r1697634
