On Thu, Sep 24, 2015 at 5:32 PM, Eric Covener <[email protected]> wrote:
> On Thu, Sep 24, 2015 at 11:14 AM, Yann Ylavic <[email protected]> wrote:
>> Wouldn't disable pipelining (and EOR purpose)?
>
> Didn't consider it / never understood it well. After doing the minimum
> amt of homework -- maybe check_pipeline could somehow be called early
> in the EOR cleanup so this kind of flush would occur before the
> transaction is logged, rather than in
> ap_process_request_after_handler?
How about:
Index: modules/ssl/ssl_engine_io.c
===================================================================
--- modules/ssl/ssl_engine_io.c (revision 1704850)
+++ modules/ssl/ssl_engine_io.c (working copy)
@@ -474,7 +474,8 @@
* output is buffered) so the performance impact of doing it
* unconditionally should be minimal.
*/
- if (bio_filter_out_flush(inctx->bio_out) < 0) {
+ if (block == APR_BLOCK_READ &&
+ bio_filter_out_flush(inctx->bio_out) < 0) {
bio_filter_out_ctx_t *outctx = inctx->bio_out->ptr;
inctx->rc = outctx->rc;
return -1;
?
