On Fri, Oct 16, 2015 at 1:27 PM, Eric Covener <cove...@gmail.com> wrote: > What's with the backwards start and end there? Does the > successor/predecessor override FIRST/MIDDLE/LAST? > > > ---------- Forwarded message ---------- > From: <bugzi...@apache.org> > Date: Fri, Oct 16, 2015 at 1:24 PM > Subject: [Bug 58498] Apache 2.4.17: Regression with mod_autoindex (in > combination with Phusion Passenger) > To: b...@httpd.apache.org > > > https://bz.apache.org/bugzilla/show_bug.cgi?id=58498 > > --- Comment #2 from Rainer Jung <rainer.j...@kippdata.de> --- > I'm not an expert on passenger, but one can see the hook registration at > > https://github.com/phusion/passenger/blob/stable-5.0/src/apache2_module/Hooks.cpp > > scrolling down to the end of the file. > > The code in the file contains some handler juggling and also rules for > ordering > relative to mod_autoindex. Especially > > ap_hook_handler(start_blocking_mod_autoindex, NULL, autoindex_module, > APR_HOOK_LAST); > ap_hook_handler(end_blocking_mod_autoindex, autoindex_module, NULL, > APR_HOOK_FIRST); > > points to > > DEFINE_REQUEST_HOOK(start_blocking_mod_autoindex, startBlockingModAutoIndex) > DEFINE_REQUEST_HOOK(end_blocking_mod_autoindex, endBlockingModAutoIndex) > > which brings the following functions into the game: > > int startBlockingModAutoIndex(request_rec *r) { > RequestNote *note = getRequestNote(r); > if (note != 0 && hasModAutoIndex()) { > note->handlerBeforeModAutoIndex = r->handler; > r->handler = "";
"" is what we now call DEFAULT_HANDLER_NAME which we now use to decide nobody set a handler and things are up for grabs If this hadn't shipped I'd be inclined to just back it out and revisit the original issue later (mod_autoindex w/o mod_mime) -- but since it has, I'd just as well guide passenger to use a non-empty string here since either way, software needs to be updated. Open to other points of view though.
