On Fri, Nov 20, 2015 at 3:13 AM, Bert Huijben <[email protected]> wrote:
> > > -----Original Message----- > > From: Stefan Eissing [mailto:[email protected]] > > Sent: vrijdag 20 november 2015 10:11 > > To: [email protected] > > Subject: Re: svn commit: r1715294 - /httpd/httpd/trunk/server/core.c > > > > +1 for lowercasing and pls backport, since it just arrived as is in > 2.4.x, > i think. > > > > - apr_table_setn(r->headers_out, "Connection", > "upgrade"); > > > + apr_table_setn(r->headers_out, "Connection", > "Upgrade"); > > As the 'Connection' header technically refers to the 'Upgrade' header I > would paint both sheds in the same color. It does, yes, That's part of my motivation, the Key (field title) is generally capitalized, the values are generally lowercase, and in this case upgrade does appear twice, so it helps slightly to distinguish the two. Referring back it has appeared both ways in the specs, but RFC 7230 has buried RFC 2817 :) http://tools.ietf.org/html/rfc7230#page-57 My inclination is obvious but I don't feel strongly enough to patch this myself, will let the others do so. For reference, we actually followed the RFC 2817 conventions in 2.2... ssl_engine_io.c:#define CONNECTION_HEADER "Connection: Upgrade" ssl_engine_kernel.c: apr_table_setn(r->err_headers_out, "Connection", "Upgrade"); and it now appears both ways in the code. /shrug ssl_engine_kernel.c:#define CONNECTION_HEADER "Connection: Upgrade" ssl_engine_kernel.c: apr_table_setn(r->err_headers_out, "Connection", "Upgrade"); ssl_engine_kernel.c: * connection, and this isn't a subrequest, send an Upgrade ssl_engine_kernel.c: apr_table_mergen(r->headers_out, "Connection", "upgrade");
