Ahhh... yeah, I guess updating all the usages to do
that makes sense.

thx!

> On Jan 19, 2016, at 1:59 PM, Ruediger Pluem <[email protected]> wrote:
> 
> 
> 
> On 01/19/2016 06:45 PM, Jim Jagielski wrote:
>> 
>>> On Jan 19, 2016, at 11:09 AM, Ruediger Pluem <[email protected]> wrote:
>>> 
>>>> +    } else {
>>>> +        if (rv != APR_SUCCESS) {
>>>> +            worker->s->error_time = now;
>>>> +            worker->s->fcount += 1;
>>>> +            if (worker->s->fcount >= worker->s->fails) {
>>>> +                ap_proxy_set_wstatus('#', 1, worker);
>>> 
>>> Wouldn't it be better to use the define from mod_proxy.h instead of the 
>>> literal?
>>> 
>> 
>> ??
>> 
>> Using ap_proxy_set_wstatus() is the standard method for setting
>> or clearing the bits in the worker status.
>> 
> 
> Sorry for being confusing I meant using PROXY_WORKER_HC_FAIL_FLAG instead of 
> '#'.
> 
> Regards
> 
> RĂ¼diger

Reply via email to