Am 21.01.2016 um 01:33 schrieb Yann Ylavic:
On Thu, Jan 21, 2016 at 12:35 AM, Rainer Jung <[email protected]> wrote:
Am 21.01.2016 um 00:17 schrieb Yann Ylavic:

On Tue, Jan 19, 2016 at 4:45 PM,  <[email protected]> wrote:

Author: rjung
Date: Tue Jan 19 15:45:44 2016
New Revision: 1725551

URL: http://svn.apache.org/viewvc?rev=1725551&view=rev
Log:
Improve spatch for APLOGNO a bit.

Modified:
      httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci

Modified: httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci?rev=1725551&r1=1725550&r2=1725551&view=diff

==============================================================================
--- httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci
(original)
+++ httpd/httpd/trunk/docs/log-message-tags/find-messages.cocci Tue Jan
19 15:45:44 2016
@@ -39,9 +39,10 @@ identifier level =~ "^APLOG_(EMERG|ALERT
   expression rv, p, s, cert;
   constant char[] fmt !~ "^APLOGNO";
   identifier level =~
"^APLOG_(EMERG|ALERT|CRIT|ERR|WARNING|NOTICE|INFO|STARTUP|DEBUG)$";
+identifier fn =~ "^ssl_log_x(|r|c)error$";


Typo "ssl_log_x(|r|c)" => "ssl_log_(x|r|c)"?


Close: the functions are

- ssl_log_xerror
- ssl_log_cxerror
- ssl_log_rxerror

Ah, right.


so "xerror" is the fixed suffix. Should be fixed now by r1725837.

"^ssl_log_(|r|c)xerror$" => "^ssl_log_(r|c)?xerror$"?
Or is it some special coccinelle regex syntax?

I have chosen the same regexp style as higher above in the same file. "(|r|c) means either empty, or "r" or "c". So it results in the same matches like your proposed solution. Nothing coccinelle specific.

Regards,

Rainer

Reply via email to