On Fri, Feb 12, 2016 at 2:04 AM, <wr...@apache.org> wrote: > Author: wrowe > Date: Fri Feb 12 01:04:58 2016 > New Revision: 1729929 > [] > Modified: httpd/httpd/trunk/include/httpd.h > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/include/httpd.h?rev=1729929&r1=1729928&r2=1729929&view=diff > ============================================================================== > --- httpd/httpd/trunk/include/httpd.h (original) > +++ httpd/httpd/trunk/include/httpd.h Fri Feb 12 01:04:58 2016 > @@ -1056,6 +1056,16 @@ struct request_rec { > apr_table_t *trailers_in; > /** MIME trailer environment from the response */ > apr_table_t *trailers_out; > + > + /** Originator's DNS name, if known. NULL if DNS hasn't been checked, > + * "" if it has and no address was found. N.B. Only access this though > + * ap_get_useragent_host() */ > + char *useragent_host;
const char * ? Christophe has made some changes recently to add const to r->protocol (trunk only, can't be backported...), I think we shoudn't introduce new char* in "public" structs. > + /** have we done double-reverse DNS? -1 yes/failure, 0 not yet, > + * 1 yes/success > + * TODO: 2 bit signed bitfield when this structure is compacted > + */ > + int double_reverse; > }; I see this TODO about bitfield, but never seen it done in your commits, so I wonder where Rainer's warning comes from... Anyway, once backported (as you propose), we can hardly change it. Regards, Yann.
