On Sat, Mar 19, 2016 at 5:37 PM, Eric Covener <[email protected]> wrote:
>> The bigger question is whether or not 'none' should be case insensitive
>> or not. IMHO, it should be.
>
> yup. Looking now too.
We probably need something like this:
Index: server/core.c
===================================================================
--- server/core.c (revision 1735784)
+++ server/core.c (working copy)
@@ -4453,16 +4453,14 @@ static int core_override_type(request_rec *r)
"Can't evaluate handler expression: %s", err);
return HTTP_INTERNAL_SERVER_ERROR;
}
+ if (val != ap_strstr_c(val, "proxy:unix")) {
+ /* Retained for compatibility -- but not for UDS */
+ char *tmp = apr_pstrdup(r->pool, val);
+ ap_str_tolower(tmp);
+ val = tmp;
+ }
if (strcmp(val, "none")) {
- if (val != ap_strstr_c(val, "proxy:unix")) {
- /* Retained for compatibility -- but not for UDS */
- char *tmp = apr_pstrdup(r->pool, val);
- ap_str_tolower(tmp);
- r->handler = tmp;
- }
- else {
- r->handler = val;
- }
+ r->handler = val;
}
}
else if (conf->handler && strcmp(conf->handler, "none")) {
--
