Re: svn commit: r1741648 - in /httpd/httpd/trunk/modules/http2: h2_bucket_beam.c h2_conn_io.c h2_mplx.c h2_mplx.h h2_session.c h2_session.h h2_stream.c h2_task.h

[Yann Ylavic]

On Fri, Apr 29, 2016 at 5:21 PM,  <ic...@apache.org> wrote:
> Author: icing
> Date: Fri Apr 29 15:21:21 2016
> New Revision: 1741648
>
> URL: http://svn.apache.org/viewvc?rev=1741648&view=rev
> Log:
> mod_http2: some more cleanup on stream/task/session takedowns
>
> Modified:
>     httpd/httpd/trunk/modules/http2/h2_bucket_beam.c
[]
>
> Modified: httpd/httpd/trunk/modules/http2/h2_bucket_beam.c
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_bucket_beam.c?rev=1741648&r1=1741647&r2=1741648&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http2/h2_bucket_beam.c (original)
> +++ httpd/httpd/trunk/modules/http2/h2_bucket_beam.c Fri Apr 29 15:21:21 2016
[]
> @@ -716,6 +719,9 @@ apr_status_t h2_beam_receive(h2_bucket_b
>      if (enter_yellow(beam, &bl) == APR_SUCCESS) {
>  transfer:
>          if (beam->aborted) {
> +            if (!!APR_BRIGADE_EMPTY(beam->green)) {

Typo (double not) here probably.

> +                apr_brigade_cleanup(beam->green);
> +            }
>              status = APR_ECONNABORTED;
>              goto leave;
>          }