Re: Regression: mod_http2 continues to process abandoned connection

[Michael Kaufmann]

Hi Stefan,

Yes, the patch solves the problem for me :-) Thanks a bunch!

Regards,
Michael


Zitat von Stefan Eissing <stefan.eiss...@greenbytes.de>:

Michael, I can reproduce the problem and habe a fix. Can you test if the following patch also solves the problem for you? Thanks!

Index: modules/http2/h2_mplx.c
===================================================================
--- modules/http2/h2_mplx.c     (revision 1748955)
+++ modules/http2/h2_mplx.c     (working copy)
@@ -436,6 +436,9 @@
     if (stream->input) {
         m->tx_handles_reserved += h2_beam_get_files_beamed(stream->input);
         h2_beam_on_consumed(stream->input, NULL, NULL);
+        /* Let anyone blocked reading know that there is no more to come */
+        h2_beam_abort(stream->input);
+        /* Remove mutex after, so that abort still finds cond to signal */
         h2_beam_mutex_set(stream->input, NULL, NULL, NULL);
     }
     h2_stream_cleanup(stream);