On Fri, Aug 5, 2016 at 10:43 AM, Yann Ylavic <[email protected]> wrote:
> @@ -903,8 +903,16 @@ AP_DECLARE(void) ap_get_mime_headers_core(request_
> */
> continue;
> }
> - else if (last_field != NULL) {
>
> + if (last_field == NULL) {
> + /* Keep track of this first header line so that we can extend
> it
> + * across any obs-fold or parse it on the next loop iteration.
> + */
> + last_field = field;
> + last_len = len;
> + continue;
> + }
> +
> /* Process the previous last_field header line with all
> obs-folded
> * segments already concatinated (this is not operating on the
> * most recently read input line).
>
This patch makes it less clear that the continue; case above also avoided
the empty-line case (that was clearer in the main loop imo), while adding
the unnecessary verification of last_len != 0 from line 904, so I'd say
it's a
net loss of legibility in spite of gaining us 4 characters. Just my 2c.
