Re: svn commit: r1715880 - in /httpd/httpd/trunk: modules/aaa/ modules/cache/ modules/dav/main/ modules/filters/ modules/generators/ modules/http/ modules/http2/ modules/loggers/ modules/mappers/ modules/proxy/ modules/ssl/ server/

[William A Rowe Jr]

On Sun, Aug 7, 2016 at 12:16 AM, Christophe JAILLET <
christophe.jail...@wanadoo.fr> wrote:

>
> Anyway, while looking at it, I noticed the code below.
> I think that it is a leftover because I don't see any reason to handle
> these 2 string comparisons differently.
>
>>
Agreed, this looks like a simple oversight, feel free to simply fix trunk...


> @@ -542,7 +542,7 @@ static const char *set_qop(cmd_parms *cm
>>       if (!strcasecmp(op, "auth-int")) {
>>
> strcasecmp unchanged here.
>
>           return "AuthDigestQop auth-int is not implemented";
>>       }
>> -    else if (strcasecmp(op, "auth")) {
>> +    else if (ap_casecmpstr(op, "auth")) {
>>
> but updated there.