Re: svn commit: r1756049 - /httpd/httpd/branches/2.4.x-openssl-1.1.0-compat/modules/ssl/ssl_util.c

[Yann Ylavic]

On Thu, Aug 11, 2016 at 11:01 PM,  <rj...@apache.org> wrote:
>
> +#if OPENSSL_VERSION_NUMBER >= 0x10000000L
> +
> +static void ssl_util_thr_id(CRYPTO_THREADID *id)
> +{
> +    /* OpenSSL needs this to return an unsigned long.  On OS/390, the pthread
> +     * id is a structure twice that big.  Use the TCB pointer instead as a
> +     * unique unsigned long.
> +     */
> +#ifdef __MVS__
> +    struct PSA {
> +        char unmapped[540];
> +        unsigned long PSATOLD;
> +    } *psaptr = 0;
> +
> +    CRYPTO_THREADID_set_numeric(id, psaptr->PSATOLD);

You really mean to dereference NULL here?

> +#else
> +    CRYPTO_THREADID_set_numeric(id, (unsigned long) apr_os_thread_current());
> +#endif
> +}