On Fri, Aug 19, 2016 at 5:49 PM, William A Rowe Jr <[email protected]> wrote: > Additional issues since this patch in our maintainer mode... > > httpd-2.x/modules/ssl/ssl_engine_config.c: In function > 'ssl_cmd_SSLVerifyClient': > httpd-2.x/modules/ssl/ssl_engine_config.c:1083:27: warning: 'mode' may be > used uninitialized in this function [-Wmaybe-uninitialized] > dc->nVerifyClient = mode; > ^ > httpd-2.x/modules/ssl/ssl_engine_config.c: In function > 'ssl_cmd_SSLProxyVerify': > httpd-2.x/modules/ssl/ssl_engine_config.c:1463:33: warning: 'mode' may be > used uninitialized in this function [-Wmaybe-uninitialized] > dc->proxy->auth.verify_mode = mode; > ^ > You might assert that ssl_cmd_verify_parse always populates the third arg > except in case of error, you didn't satisfy the compiler of this fact ;-)
How couldn't it figure out that apr_pstrcat() never returns NULL? Clever compilers should really read all the docs :) Anyway, "fixed" in r1756976, thanks!
