On 9/29/2016 4:35 AM, Evgeny Kotkov wrote:
NormW<[email protected]> writes:
G/E.
Aimed 'our' C89 compiler at mod_brotli as much for interest as anything
technical) and get the following using release 0.5.2 of Brotli:
Hi,
Thanks for giving it a look.
mod_brotli is targeted against the upcoming 1.0.x series of brotli (with a
different include layout than 0.5.2, and with new BrotliEncoderTakeOutput()
API that allows zero-copy processing).
If you have the time and energy, could you please try this with the latest
development snapshot from https://github.com/google/brotli ?
This error happens because 0.5.2 doesn't have the
BrotliEncoderTakeOutput()
API. As it's undefined, the compiler assumes it returning an int, and
that results in the error.
Hi,
Just FYI, I gave this module a try building with Visual Studio 2008
(C89) against Apache 2.4.23 and it works quite nice. I did pick up your
note about the upcoming brotli 1.0.0 so I used the master.
Server version: Apache/2.4.23 (Win32)
Server built: Sep 24 2016 00:52:57
HTTP/2.0 200 OK
Date: Thu, 29 Sep 2016 17:11:20 GMT
Server: Apache/2.4.23 (Win32) OpenSSL/1.0.2i
Last-Modified: Thu, 29 Sep 2016 17:11:14 GMT
Etag: "1234-53da890a8e938-br"
Accept-Ranges: bytes
Vary: Accept-Encoding
Content-Encoding: br
Content-Length: 1746
Content-Type: text/html
X-Firefox-Spdy: h2
Thanks for the new module! I look forward to the additions you mentioned
when introducing it.
Cheers,
Gregg
