On 10/24/2016 08:54 AM, Mike Rumph wrote:
+    return status ? status : rv;
This line seems to depend on the assumption that APR_SUCCESS is coded as
zero.
Wouldn't it be better to not hard code that assumption?

I certainly hope that APR_SUCCESS is guaranteed to be zero on every platform, in perpetuum... and from an old conversation [1] on the removal of the APR_STATUS_IS_SUCCESS macro, it looks like that's the case.

--Jacob

[1] https://lists.apache.org/thread.html/9b5019c15b1d19f6899141cde46261a3b7c9515e9a7026ce94d1aeb5@1021067744@%3Cdev.apr.apache.org%3E

Reply via email to