Re: ap_get_status_line(int)

[Yann Ylavic]

On Fri, Nov 4, 2016 at 2:09 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote:
>
> What would a non-three-digit, >599 response look like? Perhaps we have
> a good case for a NULL response or a generic 500.

AFAICT, an empty reason is allowed (the space after the status is
required though).
So maybe something like the attached patch?

Index: modules/http/http_protocol.c
===================================================================
--- modules/http/http_protocol.c	(revision 1766905)
+++ modules/http/http_protocol.c	(working copy)
@@ -801,15 +801,18 @@ AP_DECLARE(const char *) ap_method_name_of(apr_poo
  * from status_lines[shortcut[i]] to status_lines[shortcut[i+1]-1];
  * or use NULL to fill the gaps.
  */
-AP_DECLARE(int) ap_index_of_response(int status)
+static int index_of_response(int status)
 {
-    static int shortcut[6] = {0, LEVEL_200, LEVEL_300, LEVEL_400,
-    LEVEL_500, RESPONSE_CODES};
+    static int shortcut[6] = {0, LEVEL_200, LEVEL_300, LEVEL_400, LEVEL_500,
+                                 RESPONSE_CODES};
     int i, pos;
 
-    if (status < 100) {               /* Below 100 is illegal for HTTP status */
-        return LEVEL_500;
+    if (status < 100) {     /* Below 100 is illegal for HTTP status */
+        return -1;
     }
+    if (status > 999) {     /* Above 999 is also illegal for HTTP status */
+        return -1;
+    }
 
     for (i = 0; i < 5; i++) {
         status -= 100;
@@ -819,13 +822,33 @@ AP_DECLARE(const char *) ap_method_name_of(apr_poo
                 return pos;
             }
             else {
-                return LEVEL_500;            /* status unknown (falls in gap) */
+                break;
             }
         }
     }
-    return LEVEL_500;                         /* 600 or above is also illegal */
+    return 0;               /* Status unknown (falls in gap) or above 600 */
 }
 
+AP_DECLARE(int) ap_index_of_response(int status)
+{
+    int index = index_of_response(status);
+    return (index <= 0) ? LEVEL_500 : index;
+}
+
+AP_DECLARE(const char *) ap_get_status_line_ex(apr_pool_t *p, int status)
+{
+    int index = index_of_response(status);
+    if (index < 0) {
+        return status_lines[LEVEL_500];
+    }
+    else if (index == 0) {
+        return apr_psprintf(p, "%i ", status);
+    }
+    else {
+        return status_lines[index];
+    }
+}
+
 AP_DECLARE(const char *) ap_get_status_line(int status)
 {
     return status_lines[ap_index_of_response(status)];