On 11/11/2016 10:15 AM, William A Rowe Jr wrote:
The patch looks reasonable to me. As you point out, fixing this in APR
might be worthwhile, but doesn't protect mod_ssl from other OpenSSL
consuming logic such as OpenLDAP auth, database connections or
other plug-ins that may leave a lingering SSL_error state lying about.
Looks good to me too -- thanks for the bump, Paul.
I haven't committed this yet because of some SSL-related test failures
in our suite when running against httpd-trunk:
- mod_session_crypto appears to be segfaulting the server for some reason
- mod_proxy tests hang the suite when run in -ssl test mode, and httpd
complains about malformed request lines
I suspect that these failures have nothing to do with this patch, but I
just want to confirm that before it goes into trunk.
--Jacob
