Re: mod_http2 and Frequent wake-ups for mpm_event

[Yann Ylavic]

On Fri, Jan 20, 2017 at 5:51 PM, Stefan Priebe - Profihost AG
<s.pri...@profihost.ag> wrote:
> Yes. Until now I got 4 traces. But all are the same pointing to apr kill
> pool. Not like before where i got many different ones.

Could you try this new patch on mod_http2 please?

Thanks,
Yann.

Index: modules/http2/h2_stream.c
===================================================================
--- modules/http2/h2_stream.c	(revision 1778313)
+++ modules/http2/h2_stream.c	(working copy)
@@ -171,21 +171,20 @@ static void prepend_response(h2_stream *stream, h2
 static apr_status_t stream_pool_cleanup(void *ctx)
 {
     h2_stream *stream = ctx;
-    apr_status_t status;
     
     ap_assert(stream->can_be_cleaned);
-    if (stream->files) {
+    /* Files are cleaned-up/closed already, just log */
+    if (APLOGctrace3(stream->session->c) && stream->files) {
         apr_file_t *file;
         int i;
         for (i = 0; i < stream->files->nelts; ++i) {
             file = APR_ARRAY_IDX(stream->files, i, apr_file_t*);
-            status = apr_file_close(file);
             ap_log_cerror(APLOG_MARK, APLOG_TRACE3, status, stream->session->c, 
                           "h2_stream(%ld-%d): destroy, closed file %d", 
                           stream->session->id, stream->id, i);
         }
-        stream->files = NULL;
     }
+    stream->files = NULL;
     return APR_SUCCESS;
 }