++1. I know that Daniel is out of pocket for a little bit so I'l
give it a coupla more days before I "restore" to the original filter
code...
> On Jan 24, 2017, at 3:46 AM, Ruediger Pluem <[email protected]> wrote:
>
>
>
> On 01/17/2017 02:48 PM, Jim Jagielski wrote:
>>
>>> On Jan 16, 2017, at 6:57 PM, Daniel Ruggeri <[email protected]> wrote:
>>>
>>> For the most part, yes except the portions that make the header presence
>>> optional (the HDR_MISSING case). Those were added as it came into the
>>> code base to handle a use case I was working on. I've added some
>>> comments inline since I won't have time to poke around myself for a
>>> while yet.
>>>
>>>
>>> For convenience, here's a link to the original code
>>>
>>> https://github.com/roadrunner2/mod-proxy-protocol/blob/master/mod_proxy_protocol.c
>>>
>>
>> Would it make sense to have the "stable" version available
>> for backport, and keep in the WIP in trunk?
>>
>
> This would be an option, but apart from this I would like to see the WIP in
> trunk
> somehow fixed. Otherwise it is a perfect candidate for falling through the
> cracks
> and giving yet another surprise once we branch "whatever we name it" from
> trunk.
> IMHO easier to fix that now or even revert that part for the time being while
> people
> remember what is going on then later digging through it while hitting the
> issues.
>
> Regards
>
> Rüdiger
