On Tue, Feb 21, 2017 at 6:18 PM, <ic...@apache.org> wrote: > > Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev=1783912&r1=1783911&r2=1783912&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/http2/h2_mplx.c (original) > +++ httpd/httpd/trunk/modules/http2/h2_mplx.c Tue Feb 21 17:18:27 2017 > > @@ -256,20 +255,12 @@ h2_mplx *h2_mplx_create(conn_rec *c, apr > return NULL; > } > apr_allocator_max_free_set(allocator, ap_max_mem_free); > - apr_pool_create_ex(&m->pool, parent, NULL, allocator); > - if (!m->pool) { > - apr_allocator_destroy(allocator); > + status = apr_pool_create_ex(&m->pool, parent, NULL, allocator); > + if (status != APR_SUCCESS) { > return NULL; > } > apr_pool_tag(m->pool, "h2_mplx"); > apr_allocator_owner_set(allocator, m->pool); > - status = apr_thread_mutex_create(&mutex, APR_THREAD_MUTEX_DEFAULT, > - m->pool); > - if (status != APR_SUCCESS) { > - apr_pool_destroy(m->pool); > - return NULL; > - } > - apr_allocator_mutex_set(allocator, mutex);
I think this one is needed still (ptans/master->pool is not mutexed anymore), otherwise what will synchronize mplx's subpools? We are back to initial issue here, no?
