I am find w/ either adding both to docs and TAKE1 or
dropping the extra. Whatever we want/decide should be
done on trunk 1st and we can add that as an addition.
> On Mar 21, 2017, at 2:27 AM, Marion & Christophe JAILLET
> <[email protected]> wrote:
>
> Hi,
>
> +static const char *cmd_servertype(cmd_parms *cmd, void *in_dconf,
>
> + const char *val)
> +{
> + [...]
>
> + else if (!strcasecmp(val, "FPM") || !strcasecmp(val, "PHP-FPM")) {
>
> Why?
>
> PHP-FPM is not documented, neither in the doc, nor in AP_INIT_TAKE1.
>
>
>
> In this function, ap_cstr_casecmp could alos be used for consistancy reason.
>
> Just my 2 cents,
> CJ
>
>
>
> Le 15/03/2017 à 23:30, [email protected] a écrit :
>> Author: covener
>> Date: Wed Mar 15 22:30:23 2017
>> New Revision: 1787104
>>
>> URL: http://svn.apache.org/viewvc?rev=1787104&view=rev
>> Log:
>> vote
>>
>>
>> Modified:
>> httpd/httpd/branches/2.4.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL:
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1787104&r1=1787103&r2=1787104&view=diff
>> ==============================================================================
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Wed Mar 15 22:30:23 2017
>> @@ -140,7 +140,7 @@ RELEASE SHOWSTOPPERS:
>> http://svn.apache.org/r1782482
>> http://svn.apache.org/r1782532
>> 2.4.x patch:
>> http://home.apache.org/~jim/patches/mod_proxy_fcgi-v3.patch
>> - +1: jim
>> + +1: jim, covener
>> PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
>> [ start all new proposals below, under PATCHES PROPOSED. ]
>>
>>
>>
>
