On Tue, Mar 28, 2017 at 5:47 PM, Yann Ylavic <ylavic....@gmail.com> wrote:
> On Wed, Mar 15, 2017 at 10:29 AM, Joe Orton <jor...@redhat.com> wrote:
>> There seems to be some weird regressions in this. A mis-configuration
>> like:
>>
>> Listen 127.0.0.1:8025
>> Listen [::1]:8025
>> Listen 127.0.0.1:8025
>> Listen [::1]:8025
>> ListenCoresBucketsRatio 8
>>
>> ... no longer triggers a startup failure - is that expected?
>
> Is the failure really expected w/o listener buckets?
> It happens on bind ("Address already in use: AH00072: make_sock"),
> which is indeed not an issue with SO_REUSEPORT.
>
> I want to fix the leak of course but I wonder if we should:
> 1. ignore duplicated Listen directives for the ListenCoresBucketsRatio
>> 0 case only,
> 2. ignore duplicated Listen directives in any case,
> 3. fail in any case.
4. create an entry for each duplicate in the buckets, which would be a
kind of accept factor (uglily configurable)...
>
> Thoughts?
