> On Apr 10, 2017, at 11:55 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > >> >> - -1: wrowe (Premature, waiting on github.com/google/brotli 0.6 release) >> - NOTE: Awaiting next release post 0.5.2 > > > I'm amused by your rejection of my completing code review of this > submission, Jim. Classy.
Bill, your veto is quoted above. As such, with the release of 0.6 it was no long applicable. As far as your problems w/ building brotli, maybe you simply aren't doing it right. ../configure-cmake -- The C compiler identification is AppleClang 8.1.0.8020038 -- The CXX compiler identification is AppleClang 8.1.0.8020038 -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Looking for log2 -- Looking for log2 - found -- Configuring done CMake Warning (dev): Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake --help-policy CMP0042" for policy details. Use the cmake_policy command to set the policy and suppress this warning. MACOSX_RPATH is not specified for the following targets: brotlicommon brotlidec brotlienc This warning is for project developers. Use -Wno-dev to suppress it. -- Generating done -- Build files have been written to: /usr/local2/src/brotli-0.6.0/out <jimsys:src/brotli-0.6.0/out> % make Scanning dependencies of target brotlicommon [ 3%] Building C object CMakeFiles/brotlicommon.dir/common/dictionary.c.o [ 7%] Linking C shared library libbrotlicommon.dylib [ 7%] Built target brotlicommon Scanning dependencies of target brotlienc [ 11%] Building C object CMakeFiles/brotlienc.dir/enc/backward_references.c.o [ 14%] Building C object CMakeFiles/brotlienc.dir/enc/backward_references_hq.c.o [ 18%] Building C object CMakeFiles/brotlienc.dir/enc/bit_cost.c.o [ 22%] Building C object CMakeFiles/brotlienc.dir/enc/block_splitter.c.o [ 25%] Building C object CMakeFiles/brotlienc.dir/enc/brotli_bit_stream.c.o [ 29%] Building C object CMakeFiles/brotlienc.dir/enc/cluster.c.o [ 33%] Building C object CMakeFiles/brotlienc.dir/enc/compress_fragment.c.o [ 37%] Building C object CMakeFiles/brotlienc.dir/enc/compress_fragment_two_pass.c.o [ 40%] Building C object CMakeFiles/brotlienc.dir/enc/dictionary_hash.c.o [ 44%] Building C object CMakeFiles/brotlienc.dir/enc/encode.c.o [ 48%] Building C object CMakeFiles/brotlienc.dir/enc/entropy_encode.c.o [ 51%] Building C object CMakeFiles/brotlienc.dir/enc/histogram.c.o [ 55%] Building C object CMakeFiles/brotlienc.dir/enc/literal_cost.c.o [ 59%] Building C object CMakeFiles/brotlienc.dir/enc/memory.c.o [ 62%] Building C object CMakeFiles/brotlienc.dir/enc/metablock.c.o [ 66%] Building C object CMakeFiles/brotlienc.dir/enc/static_dict.c.o [ 70%] Building C object CMakeFiles/brotlienc.dir/enc/utf8_util.c.o [ 74%] Linking C shared library libbrotlienc.dylib [ 74%] Built target brotlienc Scanning dependencies of target brotlidec [ 77%] Building C object CMakeFiles/brotlidec.dir/dec/bit_reader.c.o [ 81%] Building C object CMakeFiles/brotlidec.dir/dec/decode.c.o [ 85%] Building C object CMakeFiles/brotlidec.dir/dec/huffman.c.o [ 88%] Building C object CMakeFiles/brotlidec.dir/dec/state.c.o [ 92%] Linking C shared library libbrotlidec.dylib [ 92%] Built target brotlidec Scanning dependencies of target bro [ 96%] Building C object CMakeFiles/bro.dir/tools/bro.c.o [100%] Linking C executable bro [100%] Built target bro <jimsys:src/brotli-0.6.0/out> % sudo make install [ 7%] Built target brotlicommon [ 74%] Built target brotlienc [ 92%] Built target brotlidec [100%] Built target bro Install the project... -- Install configuration: "Debug" -- Installing: /usr/local/bin/bro -- Installing: /usr/local/lib/libbrotlienc.0.6.0.dylib -- Installing: /usr/local/lib/libbrotlienc.dylib -- Installing: /usr/local/lib/libbrotlidec.0.6.0.dylib -- Installing: /usr/local/lib/libbrotlidec.dylib -- Installing: /usr/local/lib/libbrotlicommon.0.6.0.dylib -- Installing: /usr/local/lib/libbrotlicommon.dylib -- Up-to-date: /usr/local/include/brotli -- Installing: /usr/local/include/brotli/decode.h -- Installing: /usr/local/include/brotli/encode.h -- Installing: /usr/local/include/brotli/port.h -- Installing: /usr/local/include/brotli/types.h -- Installing: /usr/local/lib/pkgconfig/libbrotlicommon.pc -- Installing: /usr/local/lib/pkgconfig/libbrotlidec.pc -- Installing: /usr/local/lib/pkgconfig/libbrotlienc.pc
