On Fri, Jun 30, 2017 at 1:20 PM, Ruediger Pluem <[email protected]> wrote: > > On 06/30/2017 12:18 PM, Yann Ylavic wrote: >> >> IMHO mod_ssl shoudn't (BIO_)flush unconditionally in >> modssl_smart_shutdown(), only in the "abortive" mode of >> ssl_filter_io_shutdown(). > > I think the issue starts before that. > ap_prep_lingering_close calls the pre_close_connection hook and modules that > are registered > to this hook can perform all sort of long lasting blocking operations there. > While it can be argued that this would be a bug in the module I think the > only safe way > is to have the whole start_lingering_close_nonblocking being executed by a > worker thread.
Correct, that'd be much simpler/safer indeed. We need a new SHUTDOWN state then, right? Regards, Yann.
