I raised the question of whether the OS/X changes introduced and backported in APR are still necessary or desired, or if they should be backed out, and whether this patch, munged for APR_ macros, is needed for apr 1.6.3 tag?
Yann suggests; On Oct 16, 2017 11:31, "Yann Ylavic" <ylavic....@gmail.com> wrote: I didn't look at the APR issue still, same one? At first glance, APR_ADD_GCC_CFLAG doesn't exist, neither does --maintainer-mode try to set -Werror. Or am I missing something? Also, do we want this for APR-1.6 and 1.7? IIRC for instance our use of readdir[_r]() might trigger warnings with latest linuxes, or was this addressed? On Oct 16, 2017 11:19, <yla...@apache.org> wrote: Author: ylavic Date: Mon Oct 16 16:19:46 2017 New Revision: 1812303 URL: http://svn.apache.org/viewvc?rev=1812303&view=rev Log: Propose finalized alternative. Modified: httpd/httpd/branches/2.4.x/STATUS Modified: httpd/httpd/branches/2.4.x/STATUS URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/ STATUS?rev=1812303&r1=1812302&r2=1812303&view=diff ============================================================ ================== --- httpd/httpd/branches/2.4.x/STATUS (original) +++ httpd/httpd/branches/2.4.x/STATUS Mon Oct 16 16:19:46 2017 @@ -214,6 +214,19 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: in CTR flow, adding my +1 to note that the patch looks sane.] rjung: I think we need this also for GCC, not only recent clang. See the dev list discusion about using NOTEST_CFLAGS. + ylavic: Consider (and test ;) proposal below instead? + + *) configure.in: Fix maintainer mode with GCC/Clang. + Setting -Wstrict-prototypes in combination with -Werror leads to compiler + errors during configure checks (autoconf generates incomplete prototypes). + As suggested by Joe, add --maintainer/debugger-mode's CFLAGS in + NOTEST_CFLAGS to avoid interractions with autoconf's AC_LANG_PROGRAM. + APACHE_ADD_GCC_CFLAG now also forces -Wno-strict-prototypes for -Werror + to work despite AC_LANG_PROGRAM generating this warning by itself. + trunk patch: http://svn.apache.org/r1812263 + http://svn.apache.org/r1812301 + 2.4.x patch: svn merge -c 1812263,1812301 ^/httpd/httpd/trunk . + +1: ylavic PATCHES/ISSUES THAT ARE BEING WORKED