On Wed, Jan 10, 2018 at 2:48 PM, Eric Covener <[email protected]> wrote: > On Wed, Jan 10, 2018 at 8:27 AM, Eric Covener <[email protected]> wrote: >> On Wed, Jan 10, 2018 at 7:13 AM, Yann Ylavic <[email protected]> wrote: >>> On Wed, Jan 10, 2018 at 1:52 AM, <[email protected]> wrote: >>>> Author: covener >>>> Date: Wed Jan 10 00:52:25 2018 >>>> New Revision: 1820715 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1820715&view=rev >>>> Log: >>>> PR 61983: "Header unset Content-Type" doesn't work >>>> >>>> >>>> Submitted By: Hank Ibell <hwibell gmail.com> >>>> Committed By: covener >>> [] >>>> >>>> Modified: httpd/httpd/trunk/modules/metadata/mod_headers.c >>>> URL: >>>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/metadata/mod_headers.c?rev=1820715&r1=1820714&r2=1820715&view=diff >>>> ============================================================================== >>>> --- httpd/httpd/trunk/modules/metadata/mod_headers.c (original) >>>> +++ httpd/httpd/trunk/modules/metadata/mod_headers.c Wed Jan 10 00:52:25 >>>> 2018 >>>> @@ -806,6 +806,9 @@ static int do_headers_fixup(request_rec >>>> break; >>>> case hdr_unset: >>>> apr_table_unset(headers, hdr->header); >>>> + if (!ap_cstr_casecmp(hdr->header, "Content-Type")) { >>>> + ap_set_content_type(r, NULL); >>>> + } >>> >>> Don't we need to also check for "headers != r->headers_in && >>> !ap_cstr_casecmp(...)" here? >> >> I see what you mean, this would be in fixups (after type checker) and >> we could clobber the outbound side. Thanks. > > Hoping I followed in 1820750, thanks again!
Looks good, I didn't figure out we were doing this at several places. Thanks Eric.
