On Wed, Jan 17, 2018 at 5:17 PM, Eric Covener <[email protected]> wrote: > On Wed, Jan 17, 2018 at 10:52 AM, Stefan Eissing > <[email protected]> wrote: >> Hej Yann, >> >> could you briefly scan https://bz.apache.org/bugzilla/show_bug.cgi?id=62009 >> and let me >> know if the proposed workaround sounds reasonable? It sounds correct that h2 >> workers >> should mask these signals so that mpm threads can handle them properly. > > I think they should be blocked too. > > The reason they are unblocked is likely b/c the h2 worker threads are > created (child_init) right before apr_setup_signal_thread() is called > by the MPMs.
Ah, I read this after my comment on the PR, too bad. It makes very much sense to me. > > Maybe h2 could just call this on each new thread, but not the > primordial one child_init runs directly on? Or the MPM block signal before child_init(), it is usefull to create threads from there w/o boring with masks... Regards, Yann.
