On Thu, Feb 1, 2018 at 5:15 PM, Yann Ylavic <ylavic....@gmail.com> wrote:
> On Thu, Feb 1, 2018 at 4:32 PM, Mark Blackman <m...@exonetric.com> wrote:>
>
>> SHM clean-up is the key here and any patch that doesn’t contribute to
>> that has no immediate value for me.
>
> What you may want to try is remove "s->defn_line_number" from the id there:
>
> https://github.com/apache/httpd/blob/trunk/modules/proxy/mod_proxy_balancer.c#L787
> If your configuration file changes often, that contributes to changing
> the name of the SHM...
FWIW, here is (attached) the patch I'm thinking about.
Index: modules/proxy/mod_proxy_balancer.c
===================================================================
--- modules/proxy/mod_proxy_balancer.c (revision 1822878)
+++ modules/proxy/mod_proxy_balancer.c (working copy)
@@ -784,13 +784,12 @@ static int balancer_post_config(apr_pool_t *pconf,
* During create_proxy_config() we created a dummy id. Now that
* we have identifying info, we can create the real id
*/
- id = apr_psprintf(pconf, "%s.%s.%d.%s.%s.%u.%s",
+ id = apr_psprintf(pconf, "%s.%s.%d.%s.%s.%s",
(s->server_scheme ? s->server_scheme : "????"),
(s->server_hostname ? s->server_hostname : "???"),
(int)s->port,
(s->server_admin ? s->server_admin : "??"),
(s->defn_name ? s->defn_name : "?"),
- s->defn_line_number,
(s->error_fname ? s->error_fname : DEFAULT_ERRORLOG));
conf->id = apr_psprintf(pconf, "p%x",
ap_proxy_hashfunc(id, PROXY_HASHFUNC_DEFAULT));
