On Thu, Feb 01, 2018 at 03:01:41PM -0000, yla...@apache.org wrote: > Author: ylavic > Date: Thu Feb 1 15:01:40 2018 > New Revision: 1822879 > > URL: http://svn.apache.org/viewvc?rev=1822879&view=rev > Log: > mod_proxy: follow up to r1822849 and r1822878. > > Does r1822878's "static" APR_RETRIEVE_OPTIONAL_FN work if, say, mod_proxy is > builtin but mod_http2 isn't?
I'd guess not! > Not worth taking the risk here since it's not a fast path... > > Note: if this is an issue, I'm afraid it applies elsewhere too. The only places I found with optional fn declared static within a function were both pointlessly static and safe, fixed in r1822931. It's funny since we have a specific hook for retrieving optional functions at the right time, but it's almost never used. Most modules do it in post_config which is safe. Regards, Joe