On Fri, Mar 9, 2018 at 4:04 AM, Yann Ylavic <ylavic....@gmail.com> wrote:
> Possibly yes. Is the "skips over backreferences" concern (-0 in
> STATUS) about the "do {} while" loop in r1826289, or more generally
> about the whole match à la ap_strcmp_match() where backrefs are
> considered wildcards?I cannot really follow my own wording or recall the specifics. I don't think it was ultimately much more than the treatment of the backrefs as wildcards. While revisiting, I couldn't find any practical things that would really end up with a bad result so maybe I should retract it. I find that short function very hard to follow. Maybe it is the non-tail recursion. Considering how long 2.2 and 2.4 have such a hard time finding a worker via proxypassmatch, I wonder how many people even benefit from doing more than a comparison up to the first backrefence? But that is my lazy side speaking. I also have a minor concern about changing this behavior in 2.4. People applying maintenance could suddenly start using the non-default worker, with who knows what subtle changes when dns and connections are reused (this is more with my $bigco corporate distribution hat on, but also with empathy for the keep 2.4 stable camp.) > > On Fri, Mar 9, 2018 at 1:22 AM, Eric Covener <cove...@gmail.com> wrote: >> Did you mean to add r1826289? >> >> On Thu, Mar 8, 2018 at 5:56 PM, <yla...@apache.org> wrote: >>> Author: ylavic >>> Date: Thu Mar 8 22:56:57 2018 >>> New Revision: 1826284 >>> >>> URL: http://svn.apache.org/viewvc?rev=1826284&view=rev >>> Log: >>> Update link (STALLED, but seems related to PR 62167, should we discuss >>> it...). >>> >>> Modified: >>> httpd/httpd/branches/2.4.x/STATUS >>> >>> Modified: httpd/httpd/branches/2.4.x/STATUS >>> URL: >>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1826284&r1=1826283&r2=1826284&view=diff >>> ============================================================================== >>> --- httpd/httpd/branches/2.4.x/STATUS (original) >>> +++ httpd/httpd/branches/2.4.x/STATUS Thu Mar 8 22:56:57 2018 >>> @@ -302,7 +302,7 @@ PATCHES/ISSUES THAT ARE STALLED >>> http://svn.apache.org/r1641381 >>> ylavic: Merge patch provided (reusing new->real to avoid double >>> de_socketfy() call). >>> Also added missing r1609688 to the patchset. >>> - 2.4.x patch: >>> http://people.apache.org/~ylavic/httpd-2.4.x-ap_proxy_define_match_worker.patch >>> + 2.4.x patch: >>> http://home.apache.org/~ylavic/patches/httpd-2.4.x-ap_proxy_define_match_worker.patch >>> +1: ylavic >>> -0: covener tried to review this one in Austin with Jeff. Does the >>> added match function >>> really cover a very narrow set of parameters with the way it >>> skips over backreferences? >>> >>> >> >> >> >> -- >> Eric Covener >> cove...@gmail.com -- Eric Covener cove...@gmail.com
