On Wed, Feb 14, 2018 at 4:55 AM, <minf...@apache.org> wrote: > Author: minfrin > Date: Wed Feb 14 10:55:44 2018 > New Revision: 1824221 > > URL: http://svn.apache.org/viewvc?rev=1824221&view=rev > Log: > mod_remoteip: Add PROXY protocol support
In backporting this, was there a reason that t/modules/remoteip.t was not toggled from requires 2.5.0 to requires 2.4.30? Is there some backport missing that would cause this test to fail? Some design error in the test cases? t/modules/remoteip.t .. 1..12 # Running under perl version 5.026001 for linux # Current time local: Tue Mar 20 14:48:10 2018 # Current time GMT: Tue Mar 20 19:48:10 2018 # Using Test.pm version 1.30 # Using Apache/Test.pm version 1.41 ok 1 # testing : PROXY human readable TCP4 protocol check # expected: 200 # received: '400' not ok 2 # Failed test 2 in t/modules/remoteip.t at line 46 # testing : Content check # expected: 'PROXY-OK' # received: '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> # <html><head> # <title>400 Bad Request</title> # </head><body> # <h1>Bad Request</h1> # <p>Your browser sent a request that this server could not understand.<br /> # </p> # </body></html>' not ok 3 ok 4 # Failed test 3 in t/modules/remoteip.t at line 47 # testing : broken PROXY human readable protocol check # expected: undef # received: '400' not ok 5 # testing : Content check # expected: '' # received: '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> # <html><head> # <title>400 Bad Request</title> # </head><body> # <h1>Bad Request</h1> # <p>Your browser sent a request that this server could not understand.<br /> # </p> # </body></html>' not ok 6 # Failed test 5 in t/modules/remoteip.t at line 64 # Failed test 6 in t/modules/remoteip.t at line 65 ok 7 # testing : PROXY human readable TCP6 protocol check # expected: 200 # received: '400' not ok 8 # testing : Content check # expected: 'PROXY-OK' # received: '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> # <html><head> # <title>400 Bad Request</title> # </head><body> # <h1>Bad Request</h1> # <p>Your browser sent a request that this server could not understand.<br /> # </p> # </body></html>' not ok 9 # Failed test 8 in t/modules/remoteip.t at line 78 # Failed test 9 in t/modules/remoteip.t at line 79 ok 10 # testing : PROXY binary protocol TCP4 check # expected: 200 # received: '400' not ok 11 # testing : Content check # expected: 'PROXY-OK' # received: '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> # <html><head> # <title>400 Bad Request</title> # </head><body> # <h1>Bad Request</h1> # <p>Your browser sent a request that this server could not understand.<br /> # </p> # </body></html>' not ok 12 # Failed test 11 in t/modules/remoteip.t at line 94 # Failed test 12 in t/modules/remoteip.t at line 95 Failed 8/12 subtests Test Summary Report ------------------- t/modules/remoteip.t (Wstat: 0 Tests: 12 Failed: 8) Failed tests: 2-3, 5-6, 8-9, 11-12 Files=1, Tests=12, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.43 cusr 0.16 csys = 0.63 CPU) Result: FAIL Failed 1/1 test programs. 8/12 subtests failed. [warning] server localhost:8529 shutdown [ error] error running tests (please examine t/logs/error_log) [1]+ Exit 1 t/TEST -verbose t/apache/server_name_port.t t/modules/access.t t/modules/http2.t t/modules/remoteip.t t/modules/rewrite.t > test.log 2>&1
