+1 for release (binding). I did have http2 test failures (unreviewed) on RHEL 7.4, but it doesn’t appear to be a regression since I see the same failures against 2.4.33 on my system.
Test Summary Report (2.4.33) ------------------- t/modules/http2.t (Wstat: 0 Tests: 52 Failed: 32) Failed tests: 9-24, 33-48 Files=123, Tests=8666, 126 wallclock secs ( 3.76 usr 0.36 sys + 65.89 cusr 12.77 csys = 82.78 CPU) Result: FAIL Failed 1/123 test programs. 32/8666 subtests failed. [warning] server localhost:8529 shutdown [ error] error running tests (please examine t/logs/error_log) Test Summary Report (2.4.34) ------------------- t/modules/http2.t (Wstat: 0 Tests: 52 Failed: 32) Failed tests: 9-24, 33-48 Files=123, Tests=8666, 127 wallclock secs ( 3.64 usr 0.40 sys + 66.41 cusr 13.85 csys = 84.30 CPU) Result: FAIL Failed 1/123 test programs. 32/8666 subtests failed. [warning] server localhost:8529 shutdown [ error] error running tests (please examine t/logs/error_log) Thanks. Regards, Hank Ibell > On Jul 10, 2018, at 12:26 PM, Joe Orton <jor...@redhat.com> wrote: > > On Tue, Jul 10, 2018 at 10:03:17AM -0400, Jim Jagielski wrote: >> I'm calling a VOTE on releasing these as Apache httpd 2.4.34 GA. >> >> [X] +1: Good to go >> [ ] +0: meh >> [ ] -1: Danger Will Robinson. And why. > > +1 for release, passes test suite on Fedora 28/x86_64, sigs good, > CHANGES good... Thanks for RMing! > > Regards, Joe
