+1
> On Aug 28, 2018, at 10:30 AM, Eric Covener <[email protected]> wrote:
>
> On Tue, Aug 28, 2018 at 9:54 AM Yann Ylavic <[email protected]> wrote:
>>
>> On Tue, Aug 7, 2018 at 4:19 PM <[email protected]> wrote:
>>>
>>> Author: rjung
>>> Date: Tue Aug 7 14:19:31 2018
>>> New Revision: 1837599
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1837599&view=rev
>>> Log:
>>> Propose a few monitoring improvements.
>>>
>>> Modified:
>>> httpd/httpd/branches/2.4.x/STATUS
>>>
>>> Modified: httpd/httpd/branches/2.4.x/STATUS
>>> URL:
>>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1837599&r1=1837598&r2=1837599&view=diff
>>> ==============================================================================
>>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>>> +++ httpd/httpd/branches/2.4.x/STATUS Tue Aug 7 14:19:31 2018
>>> @@ -200,6 +200,41 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>>> 2.4.x patch: http://home.apache.org/~jim/patches/socache_redis.patch
>>> +1: jim,
>>>
>>> + *) mod_proxy: Improve the balancer member data shown
>>> + in mod_status when "ProxyStatus" is "On":
>>> + add "busy" count and show byte counts in auto
>>> + mode always in units of kilobytes.
>>> + trunk: http://svn.apache.org/r1837588
>>> + 2.4.x patch: svn merge -c 1837588 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES)
>>> + +1: rjung
>>> +
>>> + *) mod_status: Complete the data shown for async
>>> + MPMs in "auto" mode. Added number of processes,
>>> + number of stopping processes and number
>>> + of busy and idle workers.
>>> + trunk: http://svn.apache.org/r1837589
>>> + 2.4.x patch: svn merge -c 1837589 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES)
>>> + +1: rjung
>>> +
>>> + *) mod_status: Add cumulated response duration time
>>> + in milliseconds.
>>> + trunk: http://svn.apache.org/r1837590
>>> + 2.4.x patch: svn merge -c 1837590 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES and include/ap_mmn.h)
>>> + +1: rjung
>>> +
>>> + *) mod_status: Cumulate CPU time of exited child
>>> + processes in the "cu" and "cs" values.
>>> + Add CPU time of the parent process to the
>>> + "c" and "s" values.
>>> + trunk: http://svn.apache.org/r1837595
>>> + 2.4.x patch: svn merge -c 1837595 ^/httpd/httpd/trunk .
>>> + (adjust CHANGES and include/ap_mmn.h)
>>> + +1: rjung
>>
>> Those changes look fine (and great) to me, I wanted to +1 but I'm
>> wondering if they really belong in 2.4.x since the output of
>> mod_status is changed in a way that could break existing parsers.
>> I don't know the "policy" here...
>
> I think new keys in ?auto mode are OK.
