> Am 20.02.2019 um 10:53 schrieb yla...@apache.org:
> 
> Author: ylavic
> Date: Wed Feb 20 09:53:30 2019
> New Revision: 1853939
> 
> URL: http://svn.apache.org/viewvc?rev=1853939&view=rev
> Log:
> Propose.
> 
> Modified:
>    httpd/httpd/branches/2.4.x/STATUS
> 
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1853939&r1=1853938&r2=1853939&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Wed Feb 20 09:53:30 2019
> @@ -246,6 +246,23 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>      2.4.x patch: 
> http://people.apache.org/~ylavic/patches/httpd-2.4.x-forward_100_continue-v3.patch
>      +1: ylavic
> 
> +  *) mod_reqtimeout: Allow to configure (TLS-)handshake timeouts.  PR 61310.
> +     trunk patch: http://svn.apache.org/r1853901
> +                  http://svn.apache.org/r1853906
> +                  http://svn.apache.org/r1853908
> +                  http://svn.apache.org/r1853929
> +                  http://svn.apache.org/r1853935
> +     2.4.x patch: 
> http://people.apache.org/~ylavic/patches/httpd-2.4.x-reqtimeout_handshake.patch
> +     +1: ylavic

This one is giving me headaches. I added test_600_01 to master at 
https://github.com/icing/mod_h2 that triggers it.

My suspicion is that mod_reqtimeout and mod_http2 need some more coordination. 
While the handshake timeout is very useful also for h2 connections, waiting for 
GETLINE or such is less useful. 

There is more than one path how a connection can go from h1 to h2 (alpn, direct 
24 bytes detection, h1 upgrade:). Direct h2 use by curl/nghttp works, but 
mod_proxy_http2 does not.

We have a hook for protocol switching: ap_hook_protocol_switch(...) and 
probably mod_reqtimeout needs to listen to that and changes its (at least part 
of the) input/output filtering accordingly.

I will try to understand how things go sideways with the change and report back 
here.

-Stefan

Reply via email to