On Fri, Nov 22, 2019 at 09:35:01AM +0100, Ruediger Pluem wrote:
> On 11/21/2019 10:30 AM, [email protected] wrote:
> > Author: jorton
> > Date: Thu Nov 21 09:30:34 2019
> > New Revision: 1870077
...
> > +function install_apx() {
> > +    local name=$1
> > +    local version=$2
> > +    local root=https://svn.apache.org/repos/asf/apr/${name}
> > +    local prefix=${HOME}/root/${name}-${version}
> > +    local build=${HOME}/build/${name}-${version}
> > +    local config=$3
> > +    local buildconf=$4
> > +
> > +    case $version in
> > +    trunk) url=${root}/trunk ;;
> 
> This does the wrong thing for APR-UTIL trunk since there is none. I am 
> not sure if this really needs to fixed in code or if it should be just 
> documented that if APR_VERSION is set to trunk that no APR-UTIL 
> version should be set. Or we could ignore the APU_VERSION setting a 
> few lines down in case APR_VERSION is trunk.

Yes good point - I made this explicit in the docs now, which I think is 
enough.

Regards, Joe

Reply via email to