On Wed, Feb 26, 2020 at 10:39:02PM +0100, Marion & Christophe JAILLET wrote: > > Le 26/02/2020 à 18:47, [email protected] a écrit : > > Author: gbechis > > Date: Wed Feb 26 17:47:53 2020 > > New Revision: 1874545 > > > > URL: http://svn.apache.org/viewvc?rev=1874545&view=rev > > Log: > > Avoid printing NULL strings in logs > > > > Modified: > > httpd/httpd/trunk/modules/filters/mod_brotli.c > > > > Modified: httpd/httpd/trunk/modules/filters/mod_brotli.c > > URL: > > http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_brotli.c?rev=1874545&r1=1874544&r2=1874545&view=diff > > ============================================================================== > > --- httpd/httpd/trunk/modules/filters/mod_brotli.c (original) > > +++ httpd/httpd/trunk/modules/filters/mod_brotli.c Wed Feb 26 17:47:53 2020 > > @@ -419,7 +419,7 @@ static apr_status_t compress_filter(ap_f > > } > > q = ap_get_token(r->pool, &accepts, 1); > > ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r, > > - "token: '%s' - q: '%s'", token, q); > > + "token: '%s' - q: '%s'", token ?: "NULL", q); > > Is this syntax standard? This looks like a GNU extension. > > Shouldn't we use > token ? token : "NULL" > instead? > > A few google search make me think that it could be an issue with VS > (i.e. windows build) > > Just my 2c. > > CJ > you are right, committed thanks. Giovanni
signature.asc
Description: PGP signature
