Re: worker MPM test failures (was Re: Still Failing: apache/httpd#190 (trunk - 894b6a1))

[Ruediger Pluem]

On 3/22/20 6:43 PM, Yann Ylavic wrote:
> +        APR_BRIGADE_INSERT_TAIL(ctx->tmp_bb, bucket);
> +        if (do_pass
> +                || APR_BRIGADE_EMPTY(ctx->bb)
> +                || (bucket->length == (apr_size_t)-1)

How can we have a bucket length of -1 here?
What about flush buckets? Shouldn't they cause a passing here as well?

> +                || (tmp_bb_len += bucket->length) >=
> +                        conf->flush_max_threshold) {
> +            rv = ap_pass_brigade(f->next, ctx->tmp_bb);
> +            apr_brigade_cleanup(ctx->tmp_bb);
> +            if (status == APR_SUCCESS) {
> +                status = rv;
>              }

Regards

Rüdiger