On 4/21/20 6:02 PM, Joe Orton wrote: > On Tue, Apr 21, 2020 at 03:13:47PM +0100, Joe Orton wrote: >> On Tue, Apr 21, 2020 at 03:37:04PM +0200, Ruediger Pluem wrote: >>> Shouldn't that be argc < 2? >> >> It is < 3 to make the second arg truly optional, so a proto default is > > No, you were right the logic was borked. > > Updated patch which fixes this, and checks the protocol name for the > obvious typo problem attached. Thanks for reviews. > Welcome. Looks good now. Regards RĂ¼diger
- [RFC] optional Listen options= argument Joe Orton
- Re: [RFC] optional Listen options= argument Eric Covener
- Re: [RFC] optional Listen options= argument Luca Toscano
- Re: [RFC] optional Listen options= argument Ruediger Pluem
- Re: [RFC] optional Listen options= argument Joe Orton
- Re: [RFC] optional Listen options= argument Yann Ylavic
- Re: [RFC] optional Listen options= argument Joe Orton
- Re: [RFC] optional Listen options= argumen... Ruediger Pluem
- Re: [RFC] optional Listen options= argument Yann Ylavic
