On Fri, May 29, 2020 at 9:58 AM Ruediger Pluem <[email protected]> wrote:
>
> On 5/28/20 9:54 PM, [email protected] wrote:
> > Author: ylavic
> > Date: Thu May 28 19:54:02 2020
> > New Revision: 1878247
> >
> > URL: http://svn.apache.org/viewvc?rev=1878247&view=rev
> > Log:
> > .gdbinit: dump pool (pre_)cleanups [skip ci]
> >
> > Modified:
> >     httpd/httpd/trunk/.gdbinit
>
> Really nice one.

Thanks!

>
> >
> > Modified: httpd/httpd/trunk/.gdbinit
> > URL: 
> > http://svn.apache.org/viewvc/httpd/httpd/trunk/.gdbinit?rev=1878247&r1=1878246&r2=1878247&view=diff
> > ==============================================================================
> > --- httpd/httpd/trunk/.gdbinit (original)
> > +++ httpd/httpd/trunk/.gdbinit Thu May 28 19:54:02 2020
>
> > +    c_num = 0
> > +    c = darg['pre_cleanups']
> > +    while c:
> > +        c_num = c_num + 1
> > +        dc = c.dereference()
> > +        print("%s  pre_cleanup #%.2i: data = %s, plain_cleanup_fn = %s, 
> > child_cleanup_fn = %s" % (indent, c_num, dc['data'], 
> > dc['plain_cleanup_fn'].dereference(), dc['plain_cleanup_fn'].dereference()))
> > +        c = dc['next']
> > +    c = darg['cleanups']
>
> Wouldn't it make sense to do a c_num = 0 here again?

I thought it could be easier, for debugging, to talk about some pool's
cleanup number N with no ambiguity wrt pre or post cleanup.
Not a strong opinion..

Regards;
Yann.

Reply via email to