On Fri, Oct 09, 2020 at 11:57:38AM +0200, Ruediger Pluem wrote:
> Would the following patch makes sense (against trunk)?
>
> Index: server/mpm/event/event.c
> ===================================================================
> --- server/mpm/event/event.c (revision 1882251)
> +++ server/mpm/event/event.c (working copy)
> @@ -2897,8 +2897,8 @@
> * the other threads in the process needs to take us down
> * (e.g., for MaxConnectionsPerChild) it will send us SIGTERM
> */
> + apr_signal(SIGTERM, dummy_signal_handler);
> unblock_signal(SIGTERM);
> - apr_signal(SIGTERM, dummy_signal_handler);
> /* Watch for any messages from the parent over the POD */
> while (1) {
> rv = ap_mpm_podx_check(my_bucket->pod);
>
>
> It looks like a queued SIG_TERM is delivered to the current SIG_TERM handler
> immediately after we unblocked it before we could
> change the handler.
Oh, very nice catch. Yes that looks exactly right, +1.
Regards, Joe
