On Fri, Oct 30, 2020 at 09:25:05PM +0100, Ruediger Pluem wrote: > Are the following ones good candidates? They also do LDAP and SSL tests which > could be interesting as I guess that Focal has newer > LDAP and SSL libs compared to Bionic:
I'm a bit worried about running pool-debug tests more since they seem the most fragile, but yes probably worthwhile for these cases. Looks like Focal has OpenSSL 1.1.1f vs 1.1.1 on Bionic so definitely good valu in doing more on the SSL side. (really need a test with OpenSSL 3.0 branch as well somehow...) > # > ------------------------------------------------------------------------- > - name: Linux Ubuntu, APR 1.7.x, APR-util 1.7.x > env: APR_VERSION=1.7.x APU_VERSION=1.7.x > CONFIG="--enable-mods-shared=reallyall" > APU_CONFIG="--with-crypto --with-ldap" > CLEAR_CACHE=1 > # > ------------------------------------------------------------------------- > - name: Linux Ubuntu, Shared MPMs (event), pool-debug, SSL/TLS variants > env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug" > APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap" > CONFIG="--enable-mods-shared=reallyall --enable-mpms-shared=all > --with-mpm=event" > TEST_MALLOC=1 TEST_SSL=1 > # > ------------------------------------------------------------------------- > - name: Linux Ubuntu, APR 1.7.0, APR-util 1.6.1, pool-debug, LDAP > env: APR_VERSION=1.7.0 APR_CONFIG="--enable-pool-debug" > APU_VERSION=1.6.1 APU_CONFIG="--with-crypto --with-ldap" > CONFIG="--enable-mods-shared=reallyall" > TEST_MALLOC=1 TEST_LDAP=1 TEST_ARGS="-defines LDAP" > TESTS="t/modules/" > > > Does this one make sense on Focal as well / shift to Focal as we have likely > a newer ubsan library there? > > - name: Linux Ubuntu, UBSan > env: NOTEST_CFLAGS="-fsanitize=undefined > -fno-sanitize-recover=undefined" NOTEST_LIBS=-lubsan > CONFIG="--enable-mods-shared=reallyall --disable-http2" > TEST_UBSAN=1 Yes, I can't seemuch value in running that on multiple platforms so moving it to Focal makes sense. > >> Also the *condition_24x_only should be unnecessary for Focal which has > >> APR 1.6 (sufficient for trunk). It's necessary for Xenial because that > >> has a too-old APR to build trunk against. > > > > Condition removed in > > Condition removed in r1882999. Thanks a lot! Regards, Joe
